feat: define workload identity and freshness contract#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkloadIdentitycovering workload, deployment, immutable revision, logical replica, provider unit, and node IDsfresh,stale,unavailable, andunknownobservation metadata with sample and collection timingEnrichedEventNDJSONIdentityResolverwith a defaultNoneworkload hook, preserving existing resolver implementations and legacy JSON shapeScope boundary
This is the first independently reviewable contract slice of #8, not completion of the issue. The current collector is node-wide, so this PR deliberately does not apply one static environment identity to every event; doing so would misattribute multiple workloads on the same node.
Still open: per-replica Linux collection; CPU, memory, network, process, restart, and availability signals; rolling replacement and adoption fixtures; controlled OTLP and Prometheus metric exports; and cross-export parity evidence.
Validation
cargo fmt --all -- --checkcargo test -p a3s-observer -p a3s-observer-commoncargo clippy -p a3s-observer -p a3s-observer-common -- -D warningsRUSTDOCFLAGS="-D warnings" cargo doc -p a3s-observer --no-depsProgresses #8 without closing it.